test: removing unnecessary optionals and increasing branch cov - 1 #2503

suyashpatil78 · 2023-10-10T07:30:17Z

Description

`🤖 Generated by Copilot at 881e2a6`

Added and updated test cases for add-edit-expense page and fixed compatibility issues with older devices. The test cases cover new scenarios for transaction fields, corporate card expenses, and autofill settings. The compatibility issues were caused by the optional chaining operator in taxGroupControl.value and currencyObjControl.value expressions in add-edit-expense.page.ts.

`🤖 Generated by Copilot at 881e2a6`

We test the edge cases of our code
We don't rely on optional chaining
We mock the data and fix the format
We are the masters of expense tracking

Walkthrough

`🤖 Generated by Copilot at 881e2a6`

Remove optional chaining operator from taxGroupControl.value and currencyObjControl.value expressions in AddEditExpensePage class to avoid runtime errors on older devices (link)
Add mock data file expense-field-obj.data to import statement in add-edit-expense-1.spec.ts for testing transaction fields (link)
Add new test case for removeCorporateCardExpense method when etxn$ observable is undefined in add-edit-expense-1.spec.ts and expect it to call goBack method (link)
Add new test case for getActionSheetOptions method when project_id is defined in add-edit-expense-1.spec.ts and expect it to return six action sheet options and verify their handlers (link)
Add new test case for getNewExpenseObservable method when autofill settings are disabled and recently used currency is undefined in add-edit-expense-3.spec.ts and expect it to return a new expense observable with home currency and source (link)
Change formatting of TestBed.inject, corporateCreditCardExpenseService, transactionService, popoverController, trackingService, orgSettingsService, and launchDarklyService statements in add-edit-expense-1.spec.ts to remove trailing commas and align closing parentheses for readability and consistency (link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link)

Clickup

app.clickup.com

Code Coverage

Please add code coverage here

UI Preview

Please add screenshots for UI changes

suyashpatil78 · 2023-10-10T07:30:52Z

src/app/fyle/add-edit-expense/add-edit-expense-1.spec.ts

        );
        expect(trackingService.showToastMessage).toHaveBeenCalledOnceWith({
          ToastContent: 'Successfully removed the card details from the expense.',
        });
      }));

+      it('should go back to my expenses page if etxn is undefined', fakeAsync(() => {


changes here

suyashpatil78 · 2023-10-10T07:31:25Z

src/app/fyle/add-edit-expense/add-edit-expense-1.spec.ts

+        done();
+      });
+
+      it('should get all action sheet options and call titleCasePipe transform method if project_id is defined', (done) => {


change here

suyashpatil78 · 2023-10-10T07:32:14Z

src/app/fyle/add-edit-expense/add-edit-expense.page.ts

@@ -586,15 +586,15 @@ export class AddEditExpensePage implements OnInit {
    combineLatest(this.fg.controls.currencyObj.valueChanges, this.fg.controls.tax_group.valueChanges).subscribe(() => {
      if (
        this.fg.controls.tax_group.value &&
-        isNumber(taxGroupControl.value?.percentage) &&


If we have checked for this.fg.controls.tax_group.value, then no need to check for nullity again

suyashpatil78 · 2023-10-10T07:33:06Z

src/app/fyle/add-edit-expense/add-edit-expense.page.ts

        this.fg.controls.currencyObj.value
      ) {
        const amount =
-          currencyObjControl.value?.amount - currencyObjControl.value?.amount / (taxGroupControl.value?.percentage + 1);
+          currencyObjControl.value.amount - currencyObjControl.value.amount / (taxGroupControl.value.percentage + 1);


If we have checked for this.fg.controls.currencyObj.value, then no need to check again

suyashpatil78 · 2023-10-10T07:33:13Z

src/app/fyle/add-edit-expense/add-edit-expense.page.ts


        const formattedAmount = this.currencyService.getAmountWithCurrencyFraction(
          amount,
-          currencyObjControl.value?.currency
+          currencyObjControl.value.currency


same as above

…ranches-test

hlkavya0213 · 2023-10-12T06:57:43Z

src/app/fyle/add-edit-expense/add-edit-expense-1.spec.ts

+
+        let actionSheetOptions;
+
+        component.getActionSheetOptions().subscribe((res) => {


let's name the variables with proper names based on context. res can be what is the response we get eg: like bankAccountResponse, transactionsResponse etc

here it can be actionSheetOptionsResponse

yes, changing...

hlkavya0213 · 2023-10-12T06:58:55Z

src/app/fyle/add-edit-expense/add-edit-expense-1.spec.ts

+        let actionSheetOptions;
+
+        component.getActionSheetOptions().subscribe((res) => {
+          actionSheetOptions = res;


why are we assigning res to actionSheetOptions? & I don't see it's usage

hlkavya0213 · 2023-10-12T06:59:14Z

src/app/fyle/add-edit-expense/add-edit-expense-3.spec.ts

+        component.recentlyUsedValues$ = of(recentlyUsedRes);
+        fixture.detectChanges();
+
+        component.getNewExpenseObservable().subscribe((res) => {


same as above

…ranches-test

…2504) * test: removing unnecessary optionals and increasing branch cov - 2 * pr comments * test: removing unnecessary optionals and increasing branch cov - 3 (#2505) * test: removing unnecessary optionals and increasing branch cov - 3 * minor * minor * test: removing unnecessary optionals and increasing branch cov - 4 (#2506) * test: removing unnecessary optionals and increasing branch cov - 4 * minor

… into rem-branches-test

github-actions · 2023-10-16T12:23:11Z

Unit Test Coverage	%	values
Statements	95.86%	( 17265 / 18010 )
Branches	93.94%	( 8704 / 9265 )
Functions	94.01%	( 5329 / 5668 )
Lines	96.02%	( 16444 / 17125 )

test: removing unnecessary optionals and increasing branch cov - 1

7291672

github-actions bot added the size/M Medium PR label Oct 10, 2023

suyashpatil78 commented Oct 10, 2023

View reviewed changes

Merge branch 'master' of github.com:fylein/fyle-mobile-app into rem-b…

881e2a6

…ranches-test

suyashpatil78 requested review from Julias0, OmkarJ13 and Chethan-Fyle October 11, 2023 08:10

OmkarJ13 approved these changes Oct 12, 2023

View reviewed changes

hlkavya0213 reviewed Oct 12, 2023

View reviewed changes

suyashpatil78 added 2 commits October 12, 2023 13:59

Merge branch 'master' of github.com:fylein/fyle-mobile-app into rem-b…

264b62d

…ranches-test

pr comments

68d86ac

suyashpatil78 requested a review from hlkavya0213 October 12, 2023 08:41

hlkavya0213 approved these changes Oct 13, 2023

View reviewed changes

suyashpatil78 and others added 2 commits October 13, 2023 18:17

Merge branch 'master' of github.com:fylein/fyle-mobile-app into rem-b…

d2dc941

…ranches-test

github-actions bot added size/L Large PR and removed size/M Medium PR labels Oct 16, 2023

Merge branch 'rem-branches-test' of github.com:fylein/fyle-mobile-app…

eb4c7f1

… into rem-branches-test

suyashpatil78 merged commit 8d1d20c into master Oct 16, 2023
4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: removing unnecessary optionals and increasing branch cov - 1 #2503

test: removing unnecessary optionals and increasing branch cov - 1 #2503

suyashpatil78 commented Oct 10, 2023 •

edited by ghost

Loading

suyashpatil78 Oct 10, 2023

suyashpatil78 Oct 10, 2023

suyashpatil78 Oct 10, 2023

suyashpatil78 Oct 10, 2023

suyashpatil78 Oct 10, 2023

hlkavya0213 Oct 12, 2023

hlkavya0213 Oct 12, 2023

suyashpatil78 Oct 12, 2023

hlkavya0213 Oct 12, 2023

hlkavya0213 Oct 12, 2023

github-actions bot commented Oct 16, 2023


		let actionSheetOptions;

		component.getActionSheetOptions().subscribe((res) => {

test: removing unnecessary optionals and increasing branch cov - 1 #2503

test: removing unnecessary optionals and increasing branch cov - 1 #2503

Conversation

suyashpatil78 commented Oct 10, 2023 • edited by ghost Loading

Description

🤖 Generated by Copilot at 881e2a6

🤖 Generated by Copilot at 881e2a6

Walkthrough

🤖 Generated by Copilot at 881e2a6

Clickup

Code Coverage

UI Preview

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Oct 16, 2023

suyashpatil78 commented Oct 10, 2023 •

edited by ghost

Loading

`🤖 Generated by Copilot at 881e2a6`

`🤖 Generated by Copilot at 881e2a6`

`🤖 Generated by Copilot at 881e2a6`